Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Compress images from png to jpg, allow click to enlarge #2787

Merged
merged 4 commits into from Mar 19, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 19, 2020

Who is this PR for?

classroom teachers, MTSS facilitators, reading specialists and literacy coaches

What problem does this PR fix?

Allows clicking to enlarge the image.

Separately, it address the slug size limit that came up in #2783 by compressing the images to jpg instead of png. Total size drops to ~16mb.

Screenshot (if adding a client-side feature)

image

Checklists

Which features or pages does this PR touch?

  • Student Profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 19, 2020

selfie

@kevinrobinson kevinrobinson merged commit 2b031f6 into master Mar 19, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the feature/optimize-reading-imgs branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant