Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Update Rails, Sprockets #2788

Merged
merged 3 commits into from Mar 19, 2020
Merged

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 19, 2020

The Rails update is from an XSS advisory that doesn't impact us. But bundle update rails also pulled in Sprockets 4 (the manifest.js change.), which seems good while we are in maintenance-all-the-things mode.

EDIT: Also added monkey patch to work around gap bug between i18n and zeitwork in Rails 6.0.2.2, see https://travis-ci.org/github/studentinsights/studentinsights/jobs/664580684#L2793 for failure, and code comments for details.

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 19, 2020

selfie

@kevinrobinson kevinrobinson merged commit 9e4f350 into master Mar 19, 2020
1 check passed
@kevinrobinson kevinrobinson deleted the patch/rails-version branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant