Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Guard check for sessionStorage even more #2790

Merged
merged 1 commit into from Mar 25, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 24, 2020

This can raise in some edge cases where storage is disabled; in those cases on Safari even attempting to read window.sessionStorage raises. This adds a more conservative guard around that so the caching is disabled instead of raising all the way up.

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 25, 2020

selfie

@kevinrobinson kevinrobinson merged commit 1c0fdbb into master Mar 25, 2020
@kevinrobinson kevinrobinson deleted the patch/session-storage-guarding branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant