Reading: Add STAR reading to comprehension, with box and line chart (v2)#2791
Merged
Conversation
4 tasks
Contributor
Author
|
hrm, blocked on Travis issues at the moment |
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is replacing #2778
Who is this PR for?
K5 reading folks
What problem does this PR fix?
STAR wasn't included in the reader profile.
What does this PR do?
Adds in a tab, and a view for STAR reading, refactoring a few pieces along the way. Highlighting uses the same heuristic folks decided on in the class lists (<30th percentile), and the code abstracts that out.
Data is provided by updating
reader_profile.rbto re-use some of theStudentProfileChartDataclass for querying and shape of the data. In the UI, parts<BoxChart />is factored out into pure structural UI elements so it can be re-used here. And the highlighting heuristic is factored out of the class list feature. No materials are added in this PR.This PR builds on what was in #2778, but also revises a bit of UI code around the
BenchmarkBoxChart,BenchmarkCohortChartand the underlying UI elements and styling. This was driven by some small style changes (eg, decoloring text on cohort charts) that revealed coupling that we don't want anymore now that these aren't UI and design elements aren't just about benchmark reading points.Screenshot (if adding a client-side feature)
Checklists
Which features or pages does this PR touch?
Does this PR use tests to help verify we can deploy these changes quickly and confidently?