Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: More handling of nil or uninterpretable values for F&P ordering and percentiles #2792

Merged
merged 3 commits into from Mar 27, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 25, 2020

Who is this PR for?

K5 folks looking at reading profiles

What problem does this PR fix?

In manual review, it came up that for some students the cohort percentiles for F&P would raise. This happened on the server from trying to sort values that were nil, which could happen when unable to interpret the F&P level.

What does this PR do?

This improves nil handling in a few places, and pushing that down all the way into FAndPInterpret. ComparableDataPoint still implements a default ordering for null data points, since it has to tolerate underlying data points that may be nullable. Separately, the real fix here is to filter all those uninterpretable data points out in the higher levels of the reader profile computation (if not, they'd be included in percentile computations). Tests all around.

Checklists

Which features or pages does this PR touch?

  • Reader profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 25, 2020

hrm, blocked on Travis issues at the moment

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 27, 2020

selfie

@kevinrobinson kevinrobinson merged commit dcbdfcf into master Mar 27, 2020
@kevinrobinson kevinrobinson deleted the patch/f-and-p-interpreter-null branch Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant