Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Fix bug in STAR highlighting for reading tab only #2793

Merged
merged 1 commit into from Mar 26, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Mar 26, 2020

Who is this PR for?

K5 reading folks

What problem does this PR fix?

There was a bug in the STAR Reading tab highlighting (but not the view or other charts). See screenshot below.

What does this PR do?

Fixes the bug; the percentile data points need to be sorted first.

Screenshot (if adding a client-side feature)

before

Screen Shot 2020-03-26 at 1 27 50 PM

after

Screen Shot 2020-03-26 at 1 52 37 PM

# Checklists *Which features or pages does this PR touch?* + [x] Reader profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Mar 26, 2020

selfie

@kevinrobinson kevinrobinson merged commit 535a079 into master Mar 26, 2020
@kevinrobinson kevinrobinson deleted the patch/star-color-matching branch Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant