Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Fix UI bug with edge case for lowest score in cohort #2800

Merged
merged 2 commits into from Apr 3, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Apr 3, 2020

Who is this PR for?

K5 reading folks

What problem does this PR fix?

If the student had the lowest score in their cohort, nothing would be shown in the comparison chart.

Screen Shot 2020-04-03 at 1 30 08 PM

What does this PR do?

Fixes the bug to not use x && y since 0 is falsy but to check it isn't undefined or null.

Checklists

Which features or pages does this PR touch?

  • Reader profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Apr 3, 2020

selfie

@kevinrobinson kevinrobinson merged commit a633d42 into master Apr 3, 2020
2 checks passed
@kevinrobinson kevinrobinson deleted the patch/cohort-comparison-bug-for-zero branch Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant