-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Sharding and parallelizing RSpec tests in CI #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This works great, and would cut total build time to ~4min! Seems worth doing because of that; the only downside is that the way the |
kevinrobinson
changed the title
Maintenance: Experiment with sharing and parallelizing RSpec tests in CI
Maintenance: Experiment with sharding and parallelizing RSpec tests in CI
Apr 3, 2020
This reverts commit 18a4036.
kevinrobinson
force-pushed
the
patch/parallelize-rspec
branch
from
April 6, 2020 19:54
9f79ff1
to
9e400bc
Compare
kevinrobinson
changed the title
Maintenance: Experiment with sharding and parallelizing RSpec tests in CI
Maintenance: Sharding and parallelizing RSpec tests in CI
Apr 6, 2020
selfie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as experimental, but going to ship it now 🚢
This PR cuts total build time to ~4min! The only downside was that the way the
CoverageChecker
worked each shard would fail, because none of the partial test runs reach 100% coverage on the expected files. So I updated this to upload the coverage artifacts, and then added another step to merge them and run the coverage check.This ran into a few issues:
SimpleCov
on each test run to produce artifacts, but uses the plain Ruby Coverage output it produces for merging the shards on its own in plain Ruby. This also lets the coverage enforcer step us just plain Ruby rather than all the gems etc.EDIT2: Verifying code coverage check works, link:
EDIT3: example:
EDIT4: 🎉