Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Highlight current time in reading grids #2803

Merged
merged 3 commits into from Apr 8, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Apr 8, 2020

Who is this PR for?

K5 teachers, internal validation

What problem does this PR fix?

On the reader profile, it's not immediately clear where "now" is when looking at reading benchmark thresholds or history for a particular student. Separately, this fixes a UI bug with the z-index for these modals when box charts are open.

What does this PR do?

Adds in that highlighting for these two uses of the reading grid. The overall "thresholds" are unchanged.

Screenshot (if adding a client-side feature)

bug:
image

unchanged:
Screen Shot 2020-04-08 at 10 24 46 AM

on profile for particular student:
Screen Shot 2020-04-08 at 10 07 43 AM

Screen Shot 2020-04-08 at 10 07 29 AM

Checklists

Which features or pages does this PR touch?

  • Reader profile
  • Reading thresholds page

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Apr 8, 2020

This includes an update to Brakeman 4.8.1.

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Apr 8, 2020

selfie

@kevinrobinson kevinrobinson merged commit f893bf9 into master Apr 8, 2020
10 checks passed
@kevinrobinson kevinrobinson deleted the feature/highlight-now-in-reading-grids branch Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant