Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Fix bug with supporting comparison to benchmark for F&P #2805

Merged
merged 4 commits into from Apr 8, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Apr 8, 2020

Who is this PR for?

K5 reading folks

What problem does this PR fix?

When calling shouldHighlight, the comparison of the current level with the benchmark level didn't properly support F&P. In code, this was ambiguous whether that function would work for all ReadingBenchmarkDataPoint types or just DIBELS.

What does this PR do?

Removes functions specific to DIBELS, and moves them into readingData to support F&P as well. Updates the comparison for F&P to use interpretation and ordering specific to those levels. Updates and adds some test cases.

Checklists

Which features or pages does this PR touch?

  • Reader profile

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Apr 8, 2020

selfie

@kevinrobinson kevinrobinson merged commit 2fc4d3c into master Apr 8, 2020
10 checks passed
@kevinrobinson kevinrobinson deleted the patch/should-highlight-f-and-p-comparison branch Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant