Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading: Update benchmark assessment breakdown to allow debugging by school cohort #2808

merged 7 commits into from Apr 17, 2020


Copy link

@kevinrobinson kevinrobinson commented Apr 16, 2020

Who is this PR for?

internal team, project leads, mostly for validating data flowing in and related features

What problem does this PR fix?

It's simpler to debug smaller cohorts, at the school level in particular. This is particularly true for validating data and features (eg, school+grade cohort percentiles for individual benchmarks).

What does this PR do?

Allows scoping by school on the Benchmark Assessment Breakdown page. This moves the filtering by school to the server, and moves the grouping by grade to the client.

Screenshot (if adding a client-side feature)

Fake local demo data:
Screen Shot 2020-04-16 at 5 38 07 PM


Which features or pages does this PR touch?

  • Reading: Benchmark assessment breakdown

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

Copy link
Contributor Author

kevinrobinson commented Apr 17, 2020


@kevinrobinson kevinrobinson merged commit 5f06187 into master Apr 17, 2020
10 checks passed
@kevinrobinson kevinrobinson deleted the feature/reading-breakdowns-narrow-cohort branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant