Maintenance: Update Rollbar handling in local dev, for manual testing#2809
Merged
kevinrobinson merged 2 commits intomasterfrom Apr 22, 2020
Merged
Maintenance: Update Rollbar handling in local dev, for manual testing#2809kevinrobinson merged 2 commits intomasterfrom
kevinrobinson merged 2 commits intomasterfrom
Conversation
… with some edge case timeout scenarios
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is this PR for?
This is for developers, trying to validate some edge cases locally.
What problem does this PR fix?
Rollbar just wasn't provided locally, and there was a place in
<SessionRenewal />that didn't guard for this and would raise. This would only happen in local development.What does this PR do?
Updates the code setting up Rollbar to provide mock reporting functions if it doesn't load. These just log to the console. This way if other call sites don't guard properly local development still works.
Does this PR use tests to help verify we can deploy these changes quickly and confidently?