Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Update Rollbar handling in local dev, for manual testing #2809

Merged
merged 2 commits into from Apr 22, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented Apr 21, 2020

Who is this PR for?

This is for developers, trying to validate some edge cases locally.

What problem does this PR fix?

Rollbar just wasn't provided locally, and there was a place in <SessionRenewal /> that didn't guard for this and would raise. This would only happen in local development.

What does this PR do?

Updates the code setting up Rollbar to provide mock reporting functions if it doesn't load. These just log to the console. This way if other call sites don't guard properly local development still works.

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented Apr 22, 2020

selfie

@kevinrobinson kevinrobinson merged commit 829afff into master Apr 22, 2020
10 checks passed
@kevinrobinson kevinrobinson deleted the experiment/timeout-problem-understanding branch Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant