Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Remove workaround for zeitwerk eager loading bug #2817

Merged
merged 12 commits into from May 18, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented May 18, 2020

This came from updating Rails, but ended up bundling a bunch in one.

  • Rails update
  • Zeitwerk monkey patch
  • Error setting up the database: PG::ObjectInUse: ERROR: database "student_insights_test" is being accessed by other users. DETAIL: There is 1 other session using the database. Not a GH issue since it still happens with only one strategy/matrix.
  • Splitting up bundle exec tasks into their own commands makes this go away, but the setup fails on the immigrant check. It doesn't fail on master. There's a migration on master that wasn't checked in to schema.rb (could update CI to check for this). This migration would have failed the immigrant check, since it didn't add foreign key constraints. This PR adds a migration with those constraints.
  • Brakeman update

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented May 18, 2020

selfie

@kevinrobinson kevinrobinson merged commit 4f0dbbd into master May 18, 2020
10 checks passed
@kevinrobinson kevinrobinson deleted the patch/rails-zeitwerk branch May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant