Maintenance: Remove workaround for zeitwerk eager loading bug#2817
Merged
Conversation
This reverts commit 4f4b32a.
Contributor
Author
|
selfie |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came from updating Rails, but ended up bundling a bunch in one.
PG::ObjectInUse: ERROR: database "student_insights_test" is being accessed by other users. DETAIL: There is 1 other session using the database.Not a GH issue since it still happens with only one strategy/matrix.bundle exectasks into their own commands makes this go away, but the setup fails on the immigrant check. It doesn't fail on master. There's a migration on master that wasn't checked in toschema.rb(could update CI to check for this). This migration would have failed the immigrant check, since it didn't add foreign key constraints. This PR adds a migration with those constraints.