Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project leads: Add page for reviewing educator labels #2819

Merged
merged 4 commits into from May 28, 2020

Conversation

kevinrobinson
Copy link
Contributor

@kevinrobinson kevinrobinson commented May 28, 2020

Who is this PR for?

project leads

What problem does this PR fix?

Within Student Insights "labels" are used as fine-grained feature switches for specific features, staged rollouts, etc. Revising these often requires communication and collaboration, so it doesn't make sense to make this entirely self-serve for project leads. But for seasonal or recurring kinds of changes, where updates are fairly well-understood, a first step towards self-serve is allowing project leads to review these settings directly.

What does this PR do?

Adds a new admin page showing the list of labels, and which educators have them applied. This information is visible in the existing admin pages, but this focuses on the labels as the concept (eg, "show me who has access to finalize class lists as a principal").

Screenshot (if adding a client-side feature)

Screen Shot 2020-05-28 at 11 33 05 AM

Screen Shot 2020-05-28 at 12 11 14 PM

Checklists

Which features or pages does this PR touch?

  • Districtwide
  • Educator: Labels review

Does this PR use tests to help verify we can deploy these changes quickly and confidently?

  • Included specs for changes
  • Improved specs for existing code in need of better test coverage
  • Manual testing made more sense here

@kevinrobinson
Copy link
Contributor Author

kevinrobinson commented May 28, 2020

selfie

@kevinrobinson kevinrobinson merged commit e846e6f into master May 28, 2020
10 checks passed
@kevinrobinson kevinrobinson deleted the feature/educator-labels-admin branch May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant