Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support transitiontime for scenes #134

Merged
merged 1 commit into from Apr 26, 2018

Conversation

Psychokiller1888
Copy link
Contributor

Running a scene supports transition time. Usefull for night table lamps in the morning 😀
To use it you have to create your scene with transitiontime specified or transitiontime in run_scene will have no effect and stay at default 400ms

@natcl natcl merged commit d9e1830 into studioimaginaire:master Apr 26, 2018
@dsifford
Copy link
Contributor

Can someone push this out to PyPI?

@natcl
Copy link
Member

natcl commented Aug 12, 2018 via email

@dsifford
Copy link
Contributor

dsifford commented Aug 13, 2018

Also, now that I'm looking at this...

It looks like @Psychokiller1888 added transition_time as a parameter to the run_scene function, but forgot to ever use it (namely, forgot to pass it to either call of the activate_scene function called within). So this PR effectively does nothing.

Was that the purpose?

@Psychokiller1888
Copy link
Contributor Author

Woot? Sorry, will push it, I effectively did not push the correct branch I guess. Didn't see, because it's working on my implementation

@Psychokiller1888
Copy link
Contributor Author

It is used, on line 1157....

@Psychokiller1888 Psychokiller1888 mentioned this pull request Aug 13, 2018
natcl added a commit that referenced this pull request Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants