Skip to content
This repository was archived by the owner on Sep 21, 2022. It is now read-only.

Fix assets manager #61

Merged
titouanmathis merged 1 commit intodevelopfrom
feature/move-assets-config-file
Jul 14, 2021
Merged

Fix assets manager #61
titouanmathis merged 1 commit intodevelopfrom
feature/move-assets-config-file

Conversation

@lusimeon
Copy link
Contributor

@lusimeon lusimeon commented Apr 12, 2021

This PR introduces fixes to AssetsManager:

  • Move assets manager configuration file in a theme configuration folder to prevent multiple configuration files in theme root. (according to WP-Toolkit #16)

@lusimeon lusimeon mentioned this pull request Apr 12, 2021
@perruche
Copy link
Contributor

perruche commented Apr 16, 2021

This is too early to merge. WP Toolkit is not currently used in this repo (because of the namespace issue see)
We might need to make a release in WPToolkit first. And publish the new version in composer

@perruche perruche self-requested a review April 16, 2021 12:22
Fix a namespace change in studiometa/wp-toolkit
@lusimeon lusimeon force-pushed the feature/move-assets-config-file branch from f670bf6 to f4016af Compare June 28, 2021 09:54
@titouanmathis
Copy link
Collaborator

The 1.0.0-alpha5 version of the studiometa/wp-toolkit package has been published with support for a custom path for the assets' configuration file.

@titouanmathis titouanmathis merged commit f1ab1ee into develop Jul 14, 2021
@titouanmathis titouanmathis deleted the feature/move-assets-config-file branch July 14, 2021 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants