This repository was archived by the owner on May 4, 2020. It is now read-only.
Add the possibility to use media function for height based media query#17
Merged
Add the possibility to use media function for height based media query#17
Conversation
perruche
reviewed
Mar 25, 2019
Contributor
|
Nice! |
Contributor
|
Will close #4 on merge 👍 |
Contributor
|
I'am not sure it's a good idea to use the same map for height and width:
What do you think ? |
Contributor
|
It all makes sense, all good for me! 👍 |
titouanmathis
suggested changes
Mar 29, 2019
Contributor
titouanmathis
left a comment
There was a problem hiding this comment.
@lusimeon you should update the documentation in the readme too
644df0d to
a24d187
Compare
titouanmathis
approved these changes
Apr 1, 2019
Contributor
|
@lusimeon you can merge your feature 😉 Note: maybe you should do it directly on Github with the big green button, it seems like closing a feature with Git Flow marks the PR as closed and not merged :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for #4.