-
Notifications
You must be signed in to change notification settings - Fork 0
Add a base font-size variable to calculate type sizes #35
Conversation
titouanmathis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some documentation is missing and a condition is missing, seems good to me otherwise :)
|
@titouanmathis If we merge this branch, spaces will be now evaluated based on Maybe we should change the @function space($space) {
...
// Return the value times the base value if our space is a number, or else we
// return the whole value, allowing us to set `auto` in our `$spaces` list.
@if (type-of($value) == 'number') {
@return $value * ($spaces-base / $font-size-base * 1rem);
} @else {
@return $value;
}
}Unfortunaly, it will create a strong dependency between |
@lusimeon I think it will be easier to maintain over time if we keep the typography and spaces configuration separate. But the specificity of this configuration should definitely be documented so that people are aware of it. |
|
There is something troubling me in this PR. The ability to set the root font size on which all other sizes are based is definitely a good feature, but this SCSS toolkit CSS output only contains classes and has no side effect on HTML elements. So I think that setting the root font size directly on the Maybe we should just add a new |
|
I am changing the base of this PR from the |
1a65d15 to
ffa5b84
Compare
ffa5b84 to
b4cf846
Compare
|
I merge this PR to send it in the first beta release of the v3.0.0 😉 |
Add a base font-size variable to calculate type sizes rather than use default size (16px)