This repository was archived by the owner on May 4, 2020. It is now read-only.
Add a grid-gutter map to allow gutter width depends on breakpoints #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perruche
approved these changes
Feb 4, 2019
titouanmathis
suggested changes
Feb 4, 2019
Contributor
titouanmathis
left a comment
titouanmathis
left a comment
There was a problem hiding this comment.
Nice!
I think we can delete the $space-gutter variable defined in the _spaces.scss file, it will not be used anymore.
I will add a simple test strategy to be able to test (manually for the moment), the output of the configuration.
titouanmathis
approved these changes
Feb 4, 2019
Contributor
titouanmathis
left a comment
titouanmathis
left a comment
There was a problem hiding this comment.
I added a folder with test files and the @studiometa/gulp-config package to test how the files are compiled.
I will add information on these test in the PR #3.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close issue #5
_grid.scss.