Closed
Conversation
Collaborator
|
Could you provide an example of SCSS which throws an error with the configuration before your changes, and examples for SCSS which throws an error and SCSS which is valid after your changes? You can follow the examples here: https://stylelint.io/user-guide/rules/font-family-no-duplicate-names/#options 😉 |
Collaborator
titouanmathis
left a comment
There was a problem hiding this comment.
I think the bug you encountered @lusimeon is an edge case that can be fixed by adding a disable comment before the erroneous lines:
// stylelint-disable-next-line order/order
@include for-each-breakpoints using ($breakpoint) {
// ...
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR add an exception for
@include for-each-breakpointsinorder/orderrule to prevent errors throw for this kind of cases :The rule will match the first
@includebut not the second one.Is it ok for you ?