Closed
Conversation
ThomasCtnt
approved these changes
Jan 21, 2020
Merged
Contributor
titouanmathis
left a comment
titouanmathis
left a comment
There was a problem hiding this comment.
Nice job!
The fixes proposed in this PR are also implemented in #12 among other fixes, so I will close this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actuall when you want to make a grid you need to do the code below to make it work on every breakpoint:
In the scss-toolkit, the way to do a grid was:
Are you ok with this?