Skip to content

Remove empty object from configuration to work with tailwind default …#7

Merged
titouanmathis merged 1 commit intostudiometa:developfrom
lusimeon:feature/fix-empty-custom-config
Jan 21, 2020
Merged

Remove empty object from configuration to work with tailwind default …#7
titouanmathis merged 1 commit intostudiometa:developfrom
lusimeon:feature/fix-empty-custom-config

Conversation

@lusimeon
Copy link
Contributor

…values

Remove empty object from configuration because it removes default values from tailwind to be generated in compiled file.
Actually, all CSS rules overwritten with empty object are not availables.

…values

Remove empty object from configuration because it removes default values from tailwind to be generated in compiled file.
Actually, all CSS rules overwritten with empty object are not availables.
@lusimeon lusimeon requested a review from perruche January 20, 2020 15:43
@perruche perruche requested review from a team and titouanmathis January 20, 2020 15:49
Copy link
Contributor

@titouanmathis titouanmathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lusimeon it was actually a deliberate choice to remove them in order to generate smaller files for projects not using Purge CSS.

But your PR makes me wonder if it was a good choice. Purge CSS can be added quite easily to any project, and it might be usefule to have all Tailwind CSS classes available to avoid jumping between their doc and our configuration.

I personnaly would approve this PR, but I would like to have some feedback from the whole @studiometa/css team :)

@titouanmathis titouanmathis requested a review from a team January 20, 2020 16:49
@perruche
Copy link
Contributor

yeah that's probably a good idea to avoid confusions.
Should we keep all the object keys in the file ?

@lusimeon
Copy link
Contributor Author

@titouanmathis I understand, maybe we can remove only one of thoses rules (like grid-layout related), however fontWeight or lineheight and some others seems necessary on every project.

Anyways, the correct way to disable a rule is to set it to false on corePlugins property.

Copy link
Contributor

@titouanmathis titouanmathis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let try a minimal configuration and keep the management of things to disable in each project.

These modifications will be published in the v1.0.0-alpha.3 version.

@titouanmathis titouanmathis merged commit 1d99a5f into studiometa:develop Jan 21, 2020
@lusimeon lusimeon deleted the feature/fix-empty-custom-config branch January 21, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants