Skip to content
This repository was archived by the owner on Nov 17, 2020. It is now read-only.

Feature/taxonomy factory - #2

Open
lusimeon wants to merge 5 commits into
feature/post-type-factoryfrom
feature/taxonomy-factory
Open

Feature/taxonomy factory#2
lusimeon wants to merge 5 commits into
feature/post-type-factoryfrom
feature/taxonomy-factory

Conversation

@lusimeon

@lusimeon lusimeon commented Mar 26, 2020

Copy link
Copy Markdown

Add taxonomy factory to factories.

@lusimeon

Copy link
Copy Markdown
Author

Need to merge #1 before.

@titouanmathis
titouanmathis requested a review from a team March 26, 2020 10:01
@ptt-homme

Copy link
Copy Markdown

@studiometa/core I'll have a look on it till tomorrow for both PRs!

Comment thread src/class-taxonomy.php Outdated
@lusimeon
lusimeon force-pushed the feature/taxonomy-factory branch 5 times, most recently from 4858f2f to 214741c Compare June 12, 2020 10:28
@lusimeon

Copy link
Copy Markdown
Author

@studiometa/wordpress Ok for review

@lusimeon
lusimeon requested a review from a team June 12, 2020 11:36

@titouanmathis titouanmathis left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor change to the example, but good job!

Comment thread readme.md Outdated
Comment thread src/Taxonomy.php
@lusimeon
lusimeon force-pushed the feature/taxonomy-factory branch from 214741c to 06d2182 Compare June 23, 2020 12:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants