Keep theme assets version #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lusimeon
force-pushed
the
bugfix/keep-theme-assets-version
branch
from
f400e58 to
18cca46
Compare
Codecov Report
@@ Coverage Diff @@
## develop #12 +/- ##
=============================================
+ Coverage 39.24% 43.31% +4.06%
- Complexity 131 132 +1
=============================================
Files 6 6
Lines 344 344
=============================================
+ Hits 135 149 +14
+ Misses 209 195 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
titouanmathis
approved these changes
Mar 18, 2021
lusimeon
force-pushed
the
bugfix/keep-theme-assets-version
branch
2 times, most recently
from
d88f29f to
ecaf73a
Compare
Theme assets are versionned depends on file content hash, so it is not a security breach to keep version public
lusimeon
force-pushed
the
bugfix/keep-theme-assets-version
branch
from
ecaf73a to
30a922c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @studiometa/wordpress
Presently, all assets version are removed on load (to prevent plugin version to be public) so we lost the pros of browser cache invalidation.
Theme assets versions are tracked depends on file content hash, so it is not a security breach to keep theirs versions public.
This PR, check if asset is loaded from theme and keep version instead of removing it.