Allow to specify a custom filepath for AssetsManager configuration #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move default configuration in a `configuration` separated folder
Codecov Report
@@ Coverage Diff @@
## develop #16 +/- ##
=============================================
- Coverage 40.92% 40.80% -0.12%
- Complexity 134 136 +2
=============================================
Files 7 7
Lines 347 348 +1
=============================================
Hits 142 142
- Misses 205 206 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
titouanmathis
approved these changes
Jun 28, 2021
Contributor
titouanmathis
left a comment
titouanmathis
left a comment
There was a problem hiding this comment.
Seems good to me, I think the config folder is a nice addition.
lusimeon
force-pushed
the
bugfix/assets-allow-custom-filepath
branch
from
4ebeb4b to
b65d059
Compare
This PHPStan configuration is already include in phpstan.neon to work with Github actions
Merged
titouanmathis
added a commit
that referenced
this pull request
Jul 14, 2021
v1.0.0-alpha5 Added - Add support for custom filepath for the AssetsManager (#16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Updated
configurationseparated folder@studiometa/wordpress are you ok with the
configlabel in theme folder?