Rewrite css in bem fashion #25

merged 14 commits into from Mar 7, 2016


None yet

1 participant


Finally getting around to using BEM and SASS in the project. I'm using BEMIT here, because it looked quite nice and actually was quite helpful!

Also fixed a notable bug with the iframe which had been bugging me for a while. Before this PR the link would be fluid however once clicked a size would be set against the dynamically loaded iFrame meaning if the container changed in width the iFrame wouldn't follow it. Now the iFrame uses the same class as the link so it scales with its container.

Also as part of this PR the htmlproofer config has been adjusted to only report on 4xx errors instead so builds don't fail unnecessarily (eg because a server is currently experiencing 5xx errors). I did try parallelising the build however I didn't notice any performance benefits at this stage.

@studioromeo studioromeo closed this Mar 2, 2016
@studioromeo studioromeo reopened this Mar 2, 2016
@studioromeo studioromeo merged commit 7821970 into master Mar 7, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
@studioromeo studioromeo deleted the bem branch Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment