Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Black text on black background, epub on dark theme #243

Closed
TheRouce opened this issue Jan 18, 2024 · 5 comments
Closed

[BUG] Black text on black background, epub on dark theme #243

TheRouce opened this issue Jan 18, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@TheRouce
Copy link

Describe the bug
Black on black when viewing epub with dark theme on

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings'
  2. Click on 'Appearance'
  3. Change theme to 'Dark'
  4. View epub

Expected behavior

  1. white on black text when using a dark theme
  2. option to override reader appearance settings

Screenshots
image
image

I don't know how visible this will be but sometimes flipping between pages I see a blink of white text then it goes black. Not sure if this helps with fixing the bug:
Peek 2024-01-18 13-16

Additional context
I did a quick search of issues and didn't see a related one, let me know if this is related to another issue or report.

@TheRouce TheRouce added the bug Something isn't working label Jan 18, 2024
@aaronleopold
Copy link
Collaborator

Hey 👋

Thanks for reporting this! Are you able to test that this bug presents in other epub files? Or is it just this one? My immediate feeling is that there is some asset/style in the epub that is overriding Stump's, which would explain why you are seeing that flash, as well.

If it does wind up being isolated to that (or a select few) epub files, there are a few ways to continue debugging:

  1. If you're able to, send me the file and I can handle figure out where and why
  2. Inspect the iframe and send me the selector for any given text element and any style definitions/overrides shown

@TheRouce
Copy link
Author

TheRouce commented Jan 19, 2024

The two screenshots are from separate files, seems to only affect a couple.

Here's the second one:
https://annas-archive.org/md5/274524bec378a5069f5e46ff2a146b55

Inspect the iframe and send me the selector for any given text element and any style definitions/overrides shown

Is this what you're asking for? ul.calibre26:nth-child(4) > li:nth-child(1) > span:nth-child(2), not super well versed in firefox's dev tools. This was the CSS Selector for white text on the same page: span.calibre6:nth-child(1)

Black text:
image
White text:
image

@aaronleopold
Copy link
Collaborator

This is exactly what I needed, thank you! I was able to reproduce and correct the issue locally with the epub file you linked, I'll be sure to put up a PR this afternoon after work with those changes 👍

@aaronleopold
Copy link
Collaborator

The latest nightly has this fix, if you're able to try it out and let me know if it resolves the issue on your end

@TheRouce
Copy link
Author

Works!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants