Catch errors when expanding and rendering mode line format strings #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit patches the mode line to display an error message if the mode line format string cannot be expanded or rendered. Currently, errors in expansion or rendering can crash StumpWM, this commit addresses that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patches the function
redraw-mode-lineto catch errors during the expansion process and during the rendering process. The motivation for this is that I have seen StumpWM users, often newer users, crash StumpWM by using a non-valid mode line format string.Should an error be caught one of two strings will be displayed in the mode line, telling the user that the mode line could not be expanded/rendered, and displaying the error that was caught.