Skip to content

Conversation

@mihailescum
Copy link
Contributor

This PR fixes issue #147, a problem with test_chains.

@codecov-io
Copy link

Codecov Report

Merging #148 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          836       836           
=========================================
  Hits           836       836           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d244b9...952329d. Read the comment docs.

@seanlaw seanlaw merged commit 711f370 into stumpy-dev:master Mar 18, 2020
@seanlaw
Copy link
Contributor

seanlaw commented Mar 18, 2020

@mexxexx According to the Github docs, if you want a PR to automatically close an issue when it is merged, I believe that the correct syntax for the branch commit needs to be "Fixed #147" rather than "Fixed Issue #147". It can also be "Fixed #147 Fixed Typo"

@mihailescum
Copy link
Contributor Author

Thanks for that info, I didn't know about this feature!

@mihailescum mihailescum deleted the fix/147_test_allc branch March 19, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants