Fix narrowing conversion issue [-Wnarrowing] #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
force-pushed
the
narrowing-conversion
branch
from
ca85faf
to
d8f767b
Compare
|
it can be a signed char though. (default char signdness is implementation defined) |
|
Good point, that's probably what was intended. I'll use that instead of |
Fixes the following issue on aarch64 with GCC 8.1:
source/editor/TerrainBrushes.cpp:138:1: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
The signedness of 'char' is implementation defined, so we need to be explicit.
akien-mga
force-pushed
the
narrowing-conversion
branch
from
d8f767b
to
4b235b2
Compare
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Nov 29, 2019
Upstream PR: stuntrally/stuntrally#18 We had until now CXXFLAGS_gcc=-Wno-narrowing, but it looks like this was incorrect because it did not fix the original issue. PR: 242272 Approved by: linimon (mentor), amdmi3 (maintainer) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@518649 35697150-7ecd-e111-bb59-0022644237b5
uqs
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Nov 29, 2019
Upstream PR: stuntrally/stuntrally#18 We had until now CXXFLAGS_gcc=-Wno-narrowing, but it looks like this was incorrect because it did not fix the original issue. PR: 242272 Approved by: linimon (mentor), amdmi3 (maintainer)
Jehops
pushed a commit
to Jehops/freebsd-ports-legacy
that referenced
this pull request
Nov 29, 2019
Upstream PR: stuntrally/stuntrally#18 We had until now CXXFLAGS_gcc=-Wno-narrowing, but it looks like this was incorrect because it did not fix the original issue. PR: 242272 Approved by: linimon (mentor), amdmi3 (maintainer) git-svn-id: svn+ssh://svn.freebsd.org/ports/head@518649 35697150-7ecd-e111-bb59-0022644237b5
|
The signed char resolves building on ppc64el. Please merge. |
|
Pinging @cryham so they can see this more easily 🙂 |
svmhdvn
pushed a commit
to svmhdvn/freebsd-ports
that referenced
this pull request
Jan 10, 2024
Upstream PR: stuntrally/stuntrally#18 We had until now CXXFLAGS_gcc=-Wno-narrowing, but it looks like this was incorrect because it did not fix the original issue. PR: 242272 Approved by: linimon (mentor), amdmi3 (maintainer)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following issue on aarch64 with GCC 8.1:
source/editor/TerrainBrushes.cpp:138:1: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
newLine is expected to take values -1, 0 or 1, so it can't be a char.