From c7339c32fc92e2acee9307f6a113d7180432f85a Mon Sep 17 00:00:00 2001 From: Stefan Weil Date: Mon, 24 Oct 2016 16:24:34 +0200 Subject: [PATCH] viewer/svutil: Fix resource leak Coverity report: CID 1164526 (#1 of 1): Resource leak in object (CTOR_DTOR_LEAK) 2. alloc_fn: Calling allocation function socket. The previous stream_ must be closed before opening a new one. Signed-off-by: Stefan Weil --- viewer/svutil.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/viewer/svutil.cpp b/viewer/svutil.cpp index c41bf04093..80e11019e5 100644 --- a/viewer/svutil.cpp +++ b/viewer/svutil.cpp @@ -422,6 +422,7 @@ SVNetwork::SVNetwork(const char* hostname, int port) { // Wait for server to show up. // Note: There is no exception handling in case the server never turns up. + Close(); stream_ = socket(addr_info->ai_family, addr_info->ai_socktype, addr_info->ai_protocol); @@ -434,6 +435,7 @@ SVNetwork::SVNetwork(const char* hostname, int port) { sleep(1); #endif + Close(); stream_ = socket(addr_info->ai_family, addr_info->ai_socktype, addr_info->ai_protocol); }