Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all):support for considering all workflows with one term #165

Merged
merged 6 commits into from Jun 27, 2022

Conversation

anshulsahni
Copy link
Contributor

@anshulsahni anshulsahni commented Jun 13, 2022

What is the requirement?

Support for a workflow_id value all which will capture all the workflows

What are the detailed changes?

  • Capturing all the workflows from github rest api, if the workflow_id=all
  • Added documentation
  • Added one example in workflows

Fixes: #54

@anshulsahni anshulsahni force-pushed the feat/support_for_all_workflows branch from e6a6dcc to 631502d Compare Jun 13, 2022
@anshulsahni anshulsahni force-pushed the feat/support_for_all_workflows branch from 631502d to b1d5a4c Compare Jun 13, 2022
@anshulsahni anshulsahni marked this pull request as ready for review Jun 13, 2022
@anshulsahni
Copy link
Contributor Author

anshulsahni commented Jun 13, 2022

@styfle Please review this PR

@anshulsahni
Copy link
Contributor Author

anshulsahni commented Jun 15, 2022

@styfle Can you please have a look at this PR

@anshulsahni
Copy link
Contributor Author

anshulsahni commented Jun 16, 2022

@styfle Please check this PR

@mikehardy
Copy link
Contributor

mikehardy commented Jun 16, 2022

@anshulsahni I'm not even the maintainer here, just listening on the repo and I find your repeated comments irritating. Just fork the repo and use your fork, or have some patience. It's open source, maintainers don't have endless time and can't drop everything at once to handle your review, right?

@anshulsahni
Copy link
Contributor Author

anshulsahni commented Jun 16, 2022

Sure @mikehardy, but you can always unwatch the PRs & be nice to others

Anyway thanks for the advice ☺️

src/index.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
anshulsahni and others added 2 commits Jun 22, 2022
Co-authored-by: Steven <steven@ceriously.com>
Co-authored-by: Steven <steven@ceriously.com>
styfle
styfle approved these changes Jun 27, 2022
@styfle styfle merged commit d2d941c into styfle:main Jun 27, 2022
1 check passed
@anshulsahni anshulsahni deleted the feat/support_for_all_workflows branch Jun 27, 2022
styfle pushed a commit that referenced this issue Jul 20, 2022
Update the version to `0.10.0` where `workflow_id` accepts the `all` value in #165.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants