New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined warnExtendDeprecated call in production mode #1938

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
3 participants
@mitoyarzun
Contributor

mitoyarzun commented Aug 21, 2018

In production mode, the function was undefined. This change makes it a noop when NODE_ENV=production.

@probablyup

D'oh thank you

@probablyup probablyup merged commit 38c81fb into styled-components:master Aug 21, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mxstbr

This comment has been minimized.

Member

mxstbr commented Aug 21, 2018

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!

Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!

@mitoyarzun mitoyarzun deleted the mitoyarzun:fix-warn-function branch Aug 21, 2018

@probablyup

This comment has been minimized.

Contributor

probablyup commented Aug 21, 2018

Out in 3.4.4, thanks for the fix!

@mitoyarzun

This comment has been minimized.

Contributor

mitoyarzun commented Aug 21, 2018

That was quick, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment