New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "no-tags" experiment #1987

Merged
merged 2 commits into from Sep 9, 2018

Conversation

Projects
None yet
1 participant
@probablyup
Contributor

probablyup commented Sep 7, 2018

In conjunction with the babel plugin and third party usage of
the library, this didn't end up panning out in a useful way and
instead introduced some irritating edge cases.

cut 1.6.4 of the babel plugin to remove the import rewriting

remove "no-tags" experiment
In conjunction with the babel plugin and third party usage of
the library, this didn't end up panning out in a useful way and
instead introduced some irritating edge cases.

@probablyup probablyup force-pushed the remove-no-tags branch from 47f8362 to 1d47259 Sep 7, 2018

@probablyup probablyup requested a review from styled-components/core Sep 7, 2018

@probablyup probablyup merged commit ba81152 into develop Sep 9, 2018

2 checks passed

bundlesize ./dist/styled-components.min.js: 14.76KB < maxSize 16KB (gzip)(1.5KB smaller than master, good job!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@probablyup probablyup deleted the remove-no-tags branch Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment