New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust when the cGS multicompose warning is fired #1993

Merged
merged 1 commit into from Sep 9, 2018

Conversation

Projects
None yet
2 participants
@probablyup
Contributor

probablyup commented Sep 9, 2018

React 16 seems to wait to unmount in some cases, which was causing
a false-positive warning to go out when there was realistically only
one instance of cGS live on the page.

Should fix the issue discussed here: #1969 (comment)

adjust when the cGS multicompose warning is fired
React 16 seems to wait to unmount in some cases, which was causing
a false-positive warning to go out when there was realistically only
one instance of cGS live on the page.

@probablyup probablyup requested a review from styled-components/core Sep 9, 2018

@kitten

kitten approved these changes Sep 9, 2018

@kitten kitten merged commit 8d56201 into develop Sep 9, 2018

2 checks passed

bundlesize ./dist/styled-components.min.js: 14.76KB < maxSize 16KB (gzip)(1.49KB smaller than master, good job!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kitten kitten deleted the adjust-cgs-concurrent-warning branch Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment