New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] fix identification of sealed tags during streaming #1997

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@probablyup
Contributor

probablyup commented Sep 10, 2018

The "sealed" concept was on the stylesheet level, when it should
have actually been on a per-tag basis. By moving the sealed status
down, we can now accurately tell when a tag has been flushed to the
client and is no longer eligible for style injection.

Same as #1996 but for v3

fix identification of sealed tags during streaming
The "sealed" concept was on the stylesheet level, when it should
have actually been on a per-tag basis. By moving the sealed status
down, we can now accurately tell when a tag has been flushed to the
client and is no longer eligible for style injection.

@probablyup probablyup requested a review from styled-components/core Sep 10, 2018

@probablyup probablyup changed the title from fix identification of sealed tags during streaming to [v3] fix identification of sealed tags during streaming Sep 10, 2018

@kitten

kitten approved these changes Sep 10, 2018

@probablyup probablyup merged commit ff01561 into master Sep 10, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
bundlesize Total bundle size is 38.82KB/39.5KB (+8B)
Details

@probablyup probablyup deleted the fix-streaming-legacy branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment