New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyframes with > 1 interpolation #2013

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
None yet
3 participants
@probablyup
Contributor

probablyup commented Sep 17, 2018

No description provided.

@probablyup probablyup requested review from Fer0x and styled-components/core Sep 17, 2018

@probablyup probablyup referenced this pull request Sep 17, 2018

Merged

Keyframes refactoring #1930

@alansouzati

This comment has been minimized.

alansouzati commented Sep 17, 2018

nice! thanks for adding a test for it 🎉

@probablyup

This comment has been minimized.

Contributor

probablyup commented Sep 17, 2018

@alansouzati thanks for writing it ;)

@probablyup probablyup merged commit fdc1190 into develop Sep 17, 2018

2 checks passed

bundlesize ./dist/styled-components.min.js: 14.96KB < maxSize 16KB (gzip)(1.3KB smaller than master, good job!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@probablyup probablyup deleted the debug-keyframes branch Sep 17, 2018

@alansouzati

This comment has been minimized.

alansouzati commented Sep 17, 2018

that was fast!!! any hopes to get a beta 6 release? 🙏

@Fer0x

This comment has been minimized.

Contributor

Fer0x commented Sep 17, 2018

Looks good, but I noticed strange behavior in this example https://codesandbox.io/s/jv3q8z9o65

Computed styles contains this:

@-webkit-keyframes yJWz{from{opacity:0;}from to{opacity:1;}}
@keyframes yJWz{from{opacity:0;}from to{opacity:1;}}

Need to reproduce it after this merge.

@probablyup

This comment has been minimized.

Contributor

probablyup commented Sep 17, 2018

@Fer0x there's a closing brace missing in opacityAnimation

beta 6 is out, just cut it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment