New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reapply my original cGS HMR change #2017

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
1 participant
@probablyup
Contributor

probablyup commented Sep 18, 2018

Someone suggested putting the count increment in cDM but that doesn't
work since the styles are injected on render and renders can happen
without cDM ever being called.

reapply my original cGS HMR change
Someone suggested putting the count increment in cDM but that doesn't
work since the styles are injected on render and renders can happen
without cDM ever being called.

@probablyup probablyup force-pushed the original-hmr-impl branch from 5caa50c to c54a6ec Sep 18, 2018

@probablyup probablyup merged commit 7187424 into develop Sep 18, 2018

2 checks passed

bundlesize ./dist/styled-components.min.js: 14.98KB < maxSize 16KB (gzip)(1.28KB smaller than master, good job!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@probablyup probablyup deleted the original-hmr-impl branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment