New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for as utility in attrs #2055

Merged
merged 2 commits into from Oct 4, 2018

Conversation

Projects
None yet
3 participants
@imbhargav5
Member

imbhargav5 commented Oct 4, 2018

Fixes #2054

  • As supplied in attrs
  • If prop 'as' is also supplied, it is preferred over attrs.
  • Test cases for the above mentioned cases

@imbhargav5 imbhargav5 requested review from probablyup and styled-components/core Oct 4, 2018

@probablyup

Nice!

@probablyup

This comment has been minimized.

Contributor

probablyup commented Oct 4, 2018

Can you add a changelog entry before merging?

@probablyup probablyup closed this Oct 4, 2018

@probablyup probablyup reopened this Oct 4, 2018

@mxstbr

mxstbr approved these changes Oct 4, 2018

Awesome

@imbhargav5 imbhargav5 merged commit f7e1d31 into develop Oct 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@imbhargav5 imbhargav5 deleted the as-attrs branch Oct 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment