New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if result of `attrs` prop function is an element #2162

Merged
merged 3 commits into from Oct 30, 2018

Conversation

Projects
None yet
3 participants
@timswalling
Member

timswalling commented Oct 26, 2018

Adds a warning if a component is used as an attrs prop, as discussed in #2117.

@mxstbr mxstbr requested a review from probablyup Oct 28, 2018

@probablyup

LGTM, thank you! Could you add a changelog entry?

@timswalling

This comment has been minimized.

Member

timswalling commented Oct 30, 2018

@probablyup done! 🙂

@probablyup probablyup merged commit ab22bcd into styled-components:master Oct 30, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mxstbr

This comment has been minimized.

Member

mxstbr commented Oct 30, 2018

Thank you so much for helping us improve styled-components! Based on our Community Guidelines every person that has a PR of any kind merged is offered an invitation to the styled-components organization—that is you right now!

Should you accept, you'll get write access to the main repository. (and a fancy styled-components logo on your GitHub profile!) You'll be able to label and close issues, merge pull requests, create new branches, etc. We want you to help us out with those things, so don't be scared to do them! Make sure to read our contribution and community guidelines, which explains all of this in more detail. Of course, if you have any questions just let me know!

@timswalling timswalling deleted the timswalling:feature/warn-if-attrs-function-returns-element branch Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment