Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add SC_DISABLE_SPEEDY runtime override #2185
This is, if nothing else, a temporary fix until #2167 is resolved.
Currently, using Percy doesn't work for my company. We are using
This PR allows a global
<script>SC_DISABLE_SPEEDY=/percy/.test(location.host)</script> <script src="/main.js></script>
referenced this pull request
Nov 8, 2018
Nov 11, 2018
added a commit
this pull request
Nov 11, 2018
@probablyup, any chance this PR could be backported to a v3 release? We need this exact behavior in order to get prerendering working (e.g. prerender.io). The problem right now is that we need to do prerendering on a production build, which results in component styles not being included in the DOM due to the use of CSSOM
Hi @mxstbr, we are attempting to upgrade to styled-components 4.1, and we're running into a bit of dependency hell trying to get all of our code and dependencies to play nice after updating (we are using TypeScript, btw). It would be immensely helpful to us if you could backport this to a v3 release so we can make use of this functionality and save the upgrade to styled-components 4 for a future day. We are currently running styled-components 3.3.3, but I'm guessing upgrading to 3.4 should be much simpler for us than upgrading to 4.1.
Thanks for considering it!