New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't warn about innerRef if wrapping a custom component #2211

Merged
merged 4 commits into from Nov 13, 2018

Conversation

Projects
None yet
4 participants
@probablyup
Contributor

probablyup commented Nov 13, 2018

Fixes #2206

@probablyup

This comment has been minimized.

Contributor

probablyup commented Nov 13, 2018

@mxstbr made one more change on how the warnings are generated

fix warnings to be per-component, rather than per file
This ensures that all warnings are emitted properly and it isn't
a whack-a-mole situation where you fix one and then another
pops up you weren't aware of.

@probablyup probablyup force-pushed the innerRef-no-warn-if-custom branch from eaab2cc to 1f7a08d Nov 13, 2018

@probablyup probablyup merged commit 4cbb721 into master Nov 13, 2018

3 checks passed

bundlesize ./dist/styled-components.min.js: 15.62KB < maxSize 16KB (gzip)(4B larger than master, careful!)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@probablyup probablyup deleted the innerRef-no-warn-if-custom branch Nov 13, 2018

@macrozone

This comment has been minimized.

macrozone commented Nov 15, 2018

nice! can we release as 4.1.2?

@probablyup

This comment has been minimized.

Contributor

probablyup commented Nov 15, 2018

Yes, soon

@donaldpipowitch

This comment has been minimized.

donaldpipowitch commented Nov 19, 2018

Really looking forward to this MR and the "innerRef" was detected on component "${displayName}". addition ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment