New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject static classnames from folded components #2239

Merged
merged 5 commits into from Nov 23, 2018

Conversation

Projects
None yet
3 participants
@probablyup
Contributor

probablyup commented Nov 23, 2018

fixes #2232

this allows for interim components that have been folded to still
be targeted

probablyup added some commits Nov 23, 2018

inject static classnames from folded components
fixes #2232

this allows for interim components that have been folded to still
be targeted

@probablyup probablyup requested review from kitten, imbhargav5 and mxstbr Nov 23, 2018

probablyup added some commits Nov 23, 2018

@mxstbr

mxstbr approved these changes Nov 23, 2018

LGTM from a cursory review

@delijah

This comment has been minimized.

delijah commented Nov 23, 2018

Can confirm fix of #2232

@probablyup probablyup merged commit 14ef7ff into master Nov 23, 2018

3 checks passed

bundlesize ./dist/styled-components.min.js: 15.62KB < maxSize 16KB (gzip)(20B larger than master, careful!)
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@probablyup probablyup deleted the hoist-static-classnames branch Nov 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment