Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach displayName to forwardRef function as described in React docs #2508

Merged
merged 2 commits into from May 11, 2019

Conversation

Projects
None yet
3 participants
@MrLoh
Copy link
Contributor

commented Apr 17, 2019

This addresses #2507

@MrLoh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

ok, I guess it wasn't that easy ;)

@MrLoh

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

This needs some more testing I think.

);
forwardRef.displayName = displayName;
WrappedStyledComponent = React.forwardRef(forwardRef);
WrappedStyledComponent.displayName = displayName;

This comment has been minimized.

Copy link
@probablyup

probablyup Apr 18, 2019

Contributor

I guess this one isn't needed if you put it on the underlying one?

This comment has been minimized.

Copy link
@MrLoh

MrLoh Apr 18, 2019

Author Contributor

Yeah but all tests fail otherwise, will need to understand how the tests check this

@probablyup probablyup merged commit 7722809 into styled-components:master May 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chasemccoy

This comment has been minimized.

Copy link

commented May 15, 2019

@probablyup Any chance of getting this published? I think it might fix an issue I am running into.

@probablyup

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

@MrLoh

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

So sorry to hear that. All the best to you, focus on getting well and thank you so much for your contributions here.

@chasemccoy

This comment has been minimized.

Copy link

commented May 16, 2019

@probablyup Oh no! Hope everything is well, and thank you for all your hard work on styled-components!

@probablyup probablyup referenced this pull request May 30, 2019

Merged

v4.2.1 #2574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.