Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove className usage checker & suppression prop #2563

Merged
merged 3 commits into from May 29, 2019

Conversation

Projects
None yet
2 participants
@probablyup
Copy link
Contributor

commented May 29, 2019

It ends up creating a ton of dev noise in nextjs due to usage of React loadable and breaks things like React strict mode for which there is no current corollary.

Fixes #2154

@probablyup probablyup requested review from mxstbr and kitten May 29, 2019

probablyup added some commits May 29, 2019

@mxstbr

mxstbr approved these changes May 29, 2019

Copy link
Member

left a comment

LGTM, let's burn it with fire 🔥

@@ -74,7 +72,7 @@ class StyledComponent extends Component<*> {
// eslint-disable-next-line no-console
console.warn(
`Functions as object-form attrs({}) keys are now deprecated and will be removed in a future version of styled-components. Switch to the new attrs(props => ({})) syntax instead for easier and more powerful composition. The attrs key in question is "${key}" on component "${displayName}".`,
`\n ${(new Error()).stack}`

This comment has been minimized.

Copy link
@mxstbr

mxstbr May 29, 2019

Member

Is there a reason why it was this way, maybe browser compat? Is this safe to change?

This comment has been minimized.

Copy link
@probablyup

probablyup May 29, 2019

Author Contributor

idk, prettier removed it so I assume a safe transform

@mxstbr mxstbr merged commit e3cefd9 into master May 29, 2019

2 checks passed

bundlesize ./dist/styled-components.min.js: 15.82KB < maxSize 16KB (gzip)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mxstbr mxstbr deleted the remove-className-checker branch May 29, 2019

@probablyup probablyup referenced this pull request May 30, 2019

Merged

v4.2.1 #2574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.