Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent component folding when interim HOCs are present #2586

Merged
merged 4 commits into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@probablyup
Copy link
Contributor

commented Jun 2, 2019

No description provided.

@probablyup probablyup requested a review from kitten Jun 2, 2019

@probablyup probablyup added the 4.0 label Jun 2, 2019

// this no longer is possible in React 16.6 because
// of the deprecation of findDOMNode; need to find an alternative
it.skip('should work in StrictMode without warnings', () => {
it('should work in StrictMode without warnings', () => {

This comment has been minimized.

Copy link
@probablyup

probablyup Jun 2, 2019

Author Contributor

this works now because of removing the className checker, so unskipped it

@probablyup probablyup requested a review from mxstbr Jun 2, 2019

probablyup added some commits Jun 2, 2019

@kitten

kitten approved these changes Jun 4, 2019

@probablyup probablyup merged commit 2b1d01e into master Jun 4, 2019

2 checks passed

bundlesize ./dist/styled-components.min.js: 15.86KB < maxSize 16KB (gzip)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@probablyup probablyup deleted the fix-interim-hoist-issue branch Jun 4, 2019

probablyup added a commit that referenced this pull request Jun 6, 2019

probablyup added a commit that referenced this pull request Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.