Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement folding of defaultProps #2597

Merged
merged 3 commits into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@probablyup
Copy link
Contributor

commented Jun 5, 2019

Supersedes #2260 by folding all nested properties including theme if passed
Fixes #2246

I specifically chose the merge-anything library because of its default handling for non plain-object types (replace, not merge.) It's about 500b gzipped so not too bad of an addition and I'm not sure we could do much better hand-rolling it.

probablyup added some commits Jun 5, 2019

implement folding of defaultProps
specifically chose the merge-anything library because of its
default handling for non plain-object types (replace, not merge)

@probablyup probablyup requested review from mxstbr and kitten Jun 5, 2019

@kitten

kitten approved these changes Jun 5, 2019

@probablyup probablyup merged commit b7d9419 into master Jun 5, 2019

2 checks passed

bundlesize ./dist/styled-components.min.js: 16.19KB < maxSize 16.25KB (gzip)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@probablyup probablyup deleted the fold-defaultProps branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.