Added useTheme hook #2765
Merged
Added useTheme hook #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: #2340 |
mxstbr
approved these changes
Sep 25, 2019
There was a problem hiding this comment.
Thank you for taking the time to submit this PR, I am good with including this, seems like a sensible addition!
@probablyup any complaints?
|
Seems fine to me, though perhaps unnecessary since we expose |
|
I don't think it is unnecessary since it makes imports easier. Thank you for all your great work! |
|
I think this is a perfectly fine API addition, let's |
!
Michae123
reviewed
Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a simple hook to recover theme context easily