Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added useTheme hook #2765

Merged
merged 2 commits into from Sep 26, 2019
Merged

Added useTheme hook #2765

merged 2 commits into from Sep 26, 2019

Conversation

@semoal
Copy link
Contributor

@semoal semoal commented Sep 24, 2019

Added a simple hook to recover theme context easily

@semoal semoal mentioned this pull request Sep 24, 2019
14 tasks
@kachkaev
Copy link
Member

@kachkaev kachkaev commented Sep 24, 2019

Related: #2340

mxstbr
mxstbr approved these changes Sep 25, 2019
Copy link
Member

@mxstbr mxstbr left a comment

Thank you for taking the time to submit this PR, I am good with including this, seems like a sensible addition!

@probablyup any complaints?

@probablyup
Copy link
Contributor

@probablyup probablyup commented Sep 25, 2019

Seems fine to me, though perhaps unnecessary since we expose ThemeContext already

@lcswillems
Copy link

@lcswillems lcswillems commented Sep 26, 2019

I don't think it is unnecessary since it makes imports easier.

Thank you for all your great work!

@mxstbr
Copy link
Member

@mxstbr mxstbr commented Sep 26, 2019

I think this is a perfectly fine API addition, let's :shipit:!

@mxstbr mxstbr merged commit 972f718 into styled-components:canary Sep 26, 2019
6 checks passed
@semoal semoal deleted the feature/useTheme branch Sep 26, 2019
Copy link

@Michae123 Michae123 left a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants