Pass empty names option to Sheet when using StyleSheetManager with custom target

[eramdam]

Fixes #2973

When looking at the thread for the above issue, I noticed that after undoing the changes from #2937, the issue was fixed.

It seems obvious that the names map change was made for a reason and I didn't want to break SSR so I settled with that solution which looks "fine" 😅

But maybe there's a better approach, if so I'd be happy to oblige 🙇‍♂️

I also updated the test for StyleSheetManager in order to mount Title both in the parent document and in the iframes, as to trigger the bug in a test environment.

[quantizor]

@eramdam changes look ok, can you add a regression test?

[eramdam]

@eramdam changes look ok, can you add a regression test?

That's what I did by adding <Title> in the test in packages/styled-components/src/models/test/StyleSheetManager.test.js test file. Should I create a new test entirely?

[quantizor]

Yes, adding that one line isn't obvious for what it's testing.

[eramdam]

Yes, adding that one line isn't obvious for what it's testing.

Fair enough! 😄 Will do!

[eramdam]

And done! 8ceffa4

[quantizor]

Looks good, thanks!

Could you also add a changelog entry?

[eramdam]

Looks good, thanks!

Could you also add a changelog entry?

Done! Wasn't completely sure if there was a specific format to follow so I used something similar to the already existing entries.

[quantizor]

That looks great, thank you!

[macrozone]

any chance that this can be released?