eliminate useless dynamic classes, store reference to folded componentStyle #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published as |
|
This doesn't quite fix #3206 yet, just realized the selectors for composed self-references need to be based on the OG static class name... |
kitten
reviewed
Aug 27, 2020
| @@ -0,0 +1,8 @@ | |||
| { | |||
| "recommendations": [ | |||
| "christian-kohler.path-intellisense", | |||
There was a problem hiding this comment.
No, just decided to add it in while I was doing other stuff 😅
kitten
reviewed
Aug 27, 2020
kitten
previously approved these changes
Aug 27, 2020
quantizor
force-pushed
the
replace-folded-amp
branch
from
8aed04c
to
020b177
Compare
…tStyle 1. this effectively deduplicates a lot of redundant CSS that is generated starting with v4 2. & self-references are now correctly resolved to the folded layer they corespond to
The engines >= 8 thing hasn't been released yet, so this is not considered a breaking change.
quantizor
force-pushed
the
replace-folded-amp
branch
from
bb8bdf7
to
094840d
Compare
Closed
This was referenced Mar 18, 2021
|
@probablyup hi, i see this #2071 use for style isolate. // Comp -> .sc-a
// color: red -> .a
// color: blue -> .b
.sc-a {}
.a { color: red }
.a + .sc-a { margin-left: 10px }
.b { color: blue }
.b + .sc-a { margin-left: 10px }It is useful for me, and now how do style isolate? Has many styled-components instants in one container at my case. Thanks for your callback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3206
this effectively deduplicates a lot of redundant CSS that is generated
starting with v4
& self-references are now correctly resolved to the folded layer they
correspond to